As someone who plays with 100 coin stars off, I am personally against this change. Vanilla 100 coins stars mean they're still in logic, so I'm now required to do them.
I could then exclude them, sure, but in general if it's something common enough to exclude like 100 coin stars then I think it's better to just not have them in the pool at all - there are times when people want items not classified as useful/progression (construction robotics in Factorio comes to mind, for example), I would like to avoid the number of hint points required for a hint to not go up because of checks i don't plan on doing, etc.

This change takes that away and forces 100 stars into the pool for all sm64 games.

If someone wanted 100 coin stars to be vanilla, I would argue they could do that today, with plando. So while this PR makes doing a thing that could already be done easier, it takes an existing option for the rando away.

I wouldn't be against having 3 options for 100 coin stars (randomized, vanilla, disabled), but at the very least I want to keep the option to have 100 coin stars simply be disabled.

Obviously this is @N00byKing 's call as world maintainer, but wanted to offer my two cents as a frequent player of sm64 in ap.

This change really doesn't seem in the spirit of the option. People leave 100 coin stars off so they don't have to do them, not because they want them to be unrandomized.

Maybe a better change here would be to rename the option to "remove 100 coin stars" and reverse the values so that it's clearer what it does.

If N00byKing separately sees value in this option, it could be changed to a choice option like this (Edit: This is also what remyjette suggested, I didn't read their comment first):

100 coin stars:
  disable: 50  # Current "off" behavior
  vanilla: 0  # Always filled with local stars using the new code from this PR
  randomized: 0  # Current "on" behavior

Obviously I don't speak for N00byKing but I would highly question the removal of the ability to completely remove 100 coin stars.

I don't mind it being a separate option as described by @NewSoupVi and @remyjette, but replacing current behavior is definitely unwanted.
As was already mentioned, the option exists so that you don't have to play these stars, not so that you know what's there.

Reworked the logic based on feedback.

I just looked at the code again and realized something.

This effectively raises the total star count by 15, since it creates additional stars to put on the 100 coin locations.
Was that the intention? These stars are logical as well, since they are marked as progression, so they aren't really "extra" either, you could be required to actually hunt these down.

If this is intentional in its current state, I feel like it should probably be documented in the tooltip

To me, it would make more sense if either:

1. These stars are not progression, as they are extra stars that get added ontop of the desired total to make the game easier.
2. These stars are progression and you're intended to get them, and as such, they get taken from the intended total, rather than creating extra stars ontop of the total.